X-Git-Url: http://wamblee.org/gitweb/?a=blobdiff_plain;f=system%2Fgeneral%2Fsrc%2Fmain%2Fjava%2Forg%2Fwamblee%2Fsystem%2Fgraph%2Fcomponent%2FCheckExternallyRequiredVisitor.java;h=67343161f66290f5b71384e65971c0131a968f13;hb=49ce7cb8387601982d5e6ef186ce206d38f6e3d7;hp=1ce53d0732e4de4d67f35785ed04604781c71215;hpb=531559394b56b0dbf817d52c8c596216550a5cbb;p=utils

diff --git a/system/general/src/main/java/org/wamblee/system/graph/component/CheckExternallyRequiredVisitor.java b/system/general/src/main/java/org/wamblee/system/graph/component/CheckExternallyRequiredVisitor.java
index 1ce53d07..67343161 100644
--- a/system/general/src/main/java/org/wamblee/system/graph/component/CheckExternallyRequiredVisitor.java
+++ b/system/general/src/main/java/org/wamblee/system/graph/component/CheckExternallyRequiredVisitor.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2008 the original author or authors.
+ * Copyright 2005-2010 the original author or authors.
  * 
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -15,31 +15,33 @@
  */
 package org.wamblee.system.graph.component;
 
-import java.util.List;
-
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
 import org.wamblee.system.core.SystemAssemblyException;
 import org.wamblee.system.graph.Edge;
 import org.wamblee.system.graph.Graph;
 import org.wamblee.system.graph.Node;
 import org.wamblee.system.graph.Visitor;
 
+import java.util.List;
+import java.util.logging.Logger;
+
 /**
  * Visitor that checks whether all required external interfaces of the container
  * are provided.
  * 
  * @author Erik Brakkee
- * 
  */
 public class CheckExternallyRequiredVisitor implements Visitor {
+    private static final Logger LOG = Logger
+        .getLogger(CheckExternallyRequiredVisitor.class.getName());
 
-    private Log LOG = LogFactory.getLog(CheckExternallyRequiredVisitor.class);
-
-    private Graph _graph;
+    private Graph graph;
 
+    /**
+     * Creates a new CheckExternallyRequiredVisitor object.
+     * 
+     */
     public CheckExternallyRequiredVisitor(Graph aGraph) {
-        _graph = aGraph;
+        graph = aGraph;
     }
 
     @Override
@@ -51,30 +53,33 @@ public class CheckExternallyRequiredVisitor implements Visitor {
     public void visitNode(Node aNode) {
         if (aNode instanceof ExternalRequiredInterfaceNode) {
             ExternalRequiredInterfaceNode required = (ExternalRequiredInterfaceNode) aNode;
-            if (!required.getRequired().isOptional()
-                    && required.getRequired().getProvider() == null) {
-                throw new SystemAssemblyException(aNode
-                        + ": External required interface is not provided");
+
+            if (!required.getRequired().isOptional() &&
+                (required.getRequired().getProvider() == null)) {
+                throw new SystemAssemblyException(aNode +
+                    ": External required interface is not provided");
             }
 
-            List<Edge> edges = _graph.findIncoming(aNode);
+            List<Edge> edges = graph.findIncoming(aNode);
 
             if (edges.isEmpty()) {
-                LOG.warn(aNode + ": Superfluous required interface");
+                LOG.warning(aNode + ": Superfluous required interface");
             }
+
             for (Edge edge : edges) {
                 Node from = edge.getFrom();
                 assert from instanceof RequiredInterfaceNode;
-                RequiredInterfaceNode reqNode = (RequiredInterfaceNode)from;
-                if (!reqNode.getRequired().isOptional()
-                        && required.getRequired().isOptional()) {
+
+                RequiredInterfaceNode reqNode = (RequiredInterfaceNode) from;
+
+                if (!reqNode.getRequired().isOptional() &&
+                    required.getRequired().isOptional()) {
                     throw new SystemAssemblyException(
-                            aNode
-                                    + ": externally required interface is optional but a corresponding internal required interface is mandatory: "
-                                    + reqNode);
+                        aNode +
+                            ": externally required interface is optional but a corresponding internal required interface is mandatory: " +
+                            reqNode);
                 }
             }
         }
     }
-
 }