X-Git-Url: http://wamblee.org/gitweb/?a=blobdiff_plain;f=impl%2Fsrc%2Fmain%2Fjava%2Forg%2Fwamblee%2Fxmlrouter%2Fimpl%2FConfigImpl.java;h=5beeed5c12da92ece9bb9833d39bbe0c0bc2241e;hb=ca624324bf36e5ba8217a6af861cbf898a40adfc;hp=789f75c5178db2da3579c10cd14f1fd96c193932;hpb=b2375f35a2f897e1417e8b5ec5b19b3257a11586;p=xmlrouter

diff --git a/impl/src/main/java/org/wamblee/xmlrouter/impl/ConfigImpl.java b/impl/src/main/java/org/wamblee/xmlrouter/impl/ConfigImpl.java
index 789f75c..5beeed5 100644
--- a/impl/src/main/java/org/wamblee/xmlrouter/impl/ConfigImpl.java
+++ b/impl/src/main/java/org/wamblee/xmlrouter/impl/ConfigImpl.java
@@ -15,14 +15,14 @@
  */
 package org.wamblee.xmlrouter.impl;
 
-import java.util.Collection;
+import java.util.ArrayList;
 import java.util.Collections;
-import java.util.LinkedHashMap;
-import java.util.Map;
-import java.util.concurrent.atomic.AtomicLong;
+import java.util.Iterator;
+import java.util.List;
 
 import org.wamblee.xmlrouter.common.Id;
 import org.wamblee.xmlrouter.config.Config;
+import org.wamblee.xmlrouter.config.Identifiable;
 
 /**
  * Default implementation of the {@link Config} interface.
@@ -31,17 +31,26 @@ import org.wamblee.xmlrouter.config.Config;
  * 
  * @param <T>
  */
-public abstract class ConfigImpl<T> implements Config<T> {
+// TODO make sure that each item inside this config is prefixed with the id of
+// the config.
+public abstract class ConfigImpl<T extends Identifiable> implements
+    ExtendedConfig<T> {
 
-    private AtomicLong next;
-    private Map<Id<T>, T> registered;
+    private Id<Config> id;
+    private List<T> registered;
 
     /**
      * Constructs the object.
      */
-    public ConfigImpl() {
-        next = new AtomicLong(1);
-        registered = new LinkedHashMap<Id<T>, T>();
+    public ConfigImpl(Id<Config> aId) {
+        // TODO test for null.
+        id = aId;
+        registered = new ArrayList<T>();
+    }
+
+    @Override
+    public Id<Config> getId() {
+        return id;
     }
 
     /*
@@ -50,15 +59,20 @@ public abstract class ConfigImpl<T> implements Config<T> {
      * @see org.wamblee.xmlrouter.config.Config#add(T)
      */
     @Override
-    public Id<T> add(T aT) {
+    public synchronized void add(T aT) {
+        // TODO test duplicate ids.
         notNull(aT);
-        long seqno = next.incrementAndGet();
-        Id<T> id = new Id<T>(seqno);
-        registered.put(id, wrap(id, aT));
-        return id;
+        registered.add(wrap(id.getId() + ".", aT));
     }
 
-    public abstract T wrap(Id<T> aId, T aT);
+    /**
+     * This is called to wrap the given object by a safer version.
+     * 
+     * @param aT
+     *            Object to wrap.
+     * @return Wrapped object.
+     */
+    public abstract T wrap(String aPrefix, T aT);
 
     /*
      * (non-Javadoc)
@@ -68,31 +82,22 @@ public abstract class ConfigImpl<T> implements Config<T> {
      * .Id)
      */
     @Override
-    public boolean remove(Id<T> aId) {
+    public synchronized boolean remove(Id<T> aId) {
         notNull(aId);
-        return registered.remove(aId) != null;
-    }
-
-    /*
-     * (non-Javadoc)
-     * 
-     * @see org.wamblee.xmlrouter.config.Config#ids()
-     */
-    @Override
-    public Collection<Id<T>> ids() {
-        return Collections.unmodifiableCollection(registered.keySet());
+        Iterator<T> i = registered.iterator();
+        while (i.hasNext()) {
+            T t = i.next();
+            if (t.getId().equals(aId)) {
+                i.remove();
+                return true;
+            }
+        }
+        return false;
     }
 
-    /*
-     * (non-Javadoc)
-     * 
-     * @see
-     * org.wamblee.xmlrouter.config.Config#get(org.wamblee.xmlrouter.common.Id)
-     */
     @Override
-    public T get(Id<T> aId) {
-        notNull(aId);
-        return registered.get(aId);
+    public List<T> values() {
+        return Collections.unmodifiableList(registered);
     }
 
     private void notNull(T aT) {