X-Git-Url: http://wamblee.org/gitweb/?a=blobdiff_plain;f=impl%2Fsrc%2Fmain%2Fjava%2Forg%2Fwamblee%2Fxmlrouter%2Fimpl%2FCompositeConfig.java;h=22052108f5dd780c5eaffc3eb23f0e90bddafca0;hb=03a6b404471945aed9d48fc1e5b8447b4a9d9413;hp=5166315e7640504643c80307c42ea782a0902a9c;hpb=e52385618670b54a5c6a4f2fbfab381bef43a905;p=xmlrouter

diff --git a/impl/src/main/java/org/wamblee/xmlrouter/impl/CompositeConfig.java b/impl/src/main/java/org/wamblee/xmlrouter/impl/CompositeConfig.java
index 5166315..2205210 100644
--- a/impl/src/main/java/org/wamblee/xmlrouter/impl/CompositeConfig.java
+++ b/impl/src/main/java/org/wamblee/xmlrouter/impl/CompositeConfig.java
@@ -15,52 +15,76 @@
  */
 package org.wamblee.xmlrouter.impl;
 
+import static org.wamblee.xmlrouter.impl.MessageUtil.*;
+
 import java.util.ArrayList;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 
 import org.wamblee.xmlrouter.common.Id;
 import org.wamblee.xmlrouter.config.Config;
+import org.wamblee.xmlrouter.config.DuplicateException;
+import org.wamblee.xmlrouter.config.Identifiable;
 
-public class CompositeConfig<T> implements ExtendedConfig<T> {
+/**
+ * Composite config. The composite config
+ * 
+ * @author Erik Brakkee
+ * 
+ * @param <T>
+ */
+public class CompositeConfig<T extends Identifiable<T>> implements
+    ExtendedConfig<T> {
 
+    private static final String READ_ONLY_INSTANCE = "read only instance";
+    private Set<Id<Config>> ids;
     private Id<Config> id;
-    private List<T> configs;
+    private List<Id<T>> valueIds;
+    private List<T> values;
 
     public CompositeConfig(Id<Config> aId) {
+        ids = new HashSet<Id<Config>>();
         id = aId;
-        configs = new ArrayList<T>();
+        valueIds = new ArrayList<Id<T>>();
+        values = new ArrayList<T>();
     }
 
     @Override
     public Id<Config> getId() {
-        // TODO test id.
         return id;
     }
 
-    public void add(Config<T> aConfig) {
-        // TODO check duplicate config.
+    public void addConfig(Config<T> aConfig) {
+        if (ids.contains(aConfig.getId())) {
+            throw new DuplicateException(aConfig.getId().toString());
+        }
+        for (T item : aConfig.values()) {
+            if (valueIds.contains(item.getId())) {
+                throw new DuplicateException(item.getId().toString());
+            }
+        }
+
+        ids.add(aConfig.getId());
         for (T item : aConfig.values()) {
-            configs.add(item);
+            valueIds.add(item.getId());
+            values.add(item);
         }
     }
 
     @Override
     public List<T> values() {
-        return configs;
+        return values;
     }
 
     @Override
     public boolean remove(Id<T> aId) {
-        notSupported();
+        notSupported(READ_ONLY_INSTANCE);
         return false;
     }
 
     @Override
     public void add(T aT) {
-        notSupported();
-    }
-
-    private void notSupported() {
-        throw new RuntimeException("readonly instance");
+        notSupported(READ_ONLY_INSTANCE);
     }
 }