Removed the table names from the persistence unit description.

[utils] / test / enterprise / src / main / java / org / wamblee / support / persistence / DatabaseUtils.java

diff --git a/test/enterprise/src/main/java/org/wamblee/support/persistence/DatabaseUtils.java b/test/enterprise/src/main/java/org/wamblee/support/persistence/DatabaseUtils.java
index 311d2da3189afcfcf09141b3b52996cc1895140d..b57cd46184e3c4293da6ca5e25c01f6aec8957cd 100644 (file)
--- a/test/enterprise/src/main/java/org/wamblee/support/persistence/DatabaseUtils.java
+++ b/test/enterprise/src/main/java/org/wamblee/support/persistence/DatabaseUtils.java
@@ -21,6 +21,7 @@ import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.logging.Level;
 import java.util.logging.Logger;
 
 import javax.sql.DataSource;
@@ -64,34 +65,67 @@ public class DatabaseUtils {
      */
     private static final String SCHEMA_PATTERN = "%";
     private DataSource dataSource;
-    private ITableFilterSimple tables;
 
-    public DatabaseUtils(DataSource aDataSource, ITableFilterSimple aTables) {
+    private IDatabaseTester dbtester;
+    /**
+     * List of connections that were created for dbtesters. 
+     * This list will be closed in the {@link #stop()} method. 
+     */
+    private List<IDatabaseConnection> connections; 
+    
+    /**
+     * Constructs the database utils. 
+     * Before use, {@link #start()} must be called. 
+     * @param aDataSource Datasource.  
+     */
+    public DatabaseUtils(DataSource aDataSource) {
         dataSource = aDataSource;
-        tables = aTables;
+        dbtester = new DataSourceDatabaseTester(dataSource);
+        connections = new ArrayList<IDatabaseConnection>(); 
     }
 
-    public IDatabaseTester createDbTester() throws Exception {
-        return createDbTester(getTableNames(tables));
+    /**
+     * Starts the database utils. 
+     */
+    public void start() { 
+        // Empty. No operation currently. 
     }
 
-    public IDatabaseTester createDbTester(String[] aTables) throws Exception {
-        IDatabaseTester dbtester = new DataSourceDatabaseTester(dataSource);
-        dbtester.setDataSet(dbtester.getConnection().createDataSet(aTables));
-        return dbtester;
+    /**
+     * Stops the database utils, closing any JDBC connections that were created
+     * by this utility. Note that connections obtained from the datasource directly 
+     * must still be closed by the user. The involved connections are only those that
+     * are created by this utility. 
+     */
+    public void stop() {
+        for (IDatabaseConnection connection: connections) { 
+            try {
+                connection.close();
+            } catch (SQLException e) {
+                LOG.log(Level.WARNING, "Could not close connection", e);
+            }
+        }
+        connections.clear();
     }
 
-    public void cleanDatabase() throws Exception {
-        cleanDatabase(tables);
+    public IDatabaseTester createDbTester(ITableFilterSimple aTables) throws Exception {
+        return createDbTester(getTableNames(aTables));
+    }
+
+    public IDatabaseTester createDbTester(String[] aTables) throws Exception {
+        IDatabaseConnection connection = dbtester.getConnection();
+        connections.add(connection);
+        dbtester.setDataSet(connection.createDataSet(aTables));
+        return dbtester;
     }
 
     public void executeOnTables(ITableFilterSimple aTables,
         final TableSetOperation aOperation) throws Exception {
-        final String[] tables = getTableNames(aTables);
+        final String[] tableNames = getTableNames(aTables);
         executeInTransaction(new JdbcUnitOfWork<Void>() {
             public Void execute(Connection aConnection) throws Exception {
-                for (int i = tables.length-1; i >= 0; i--) {
-                    aOperation.execute(tables[i]);
+                for (int i = tableNames.length - 1; i >= 0; i--) {
+                    aOperation.execute(tableNames[i]);
                 }
                 return null;
             }
@@ -100,16 +134,16 @@ public class DatabaseUtils {
 
     public void cleanDatabase(ITableFilterSimple aSelection) throws Exception {
 
-        final String[] tables = getTableNames(aSelection);
+        final String[] tableNames = getTableNames(aSelection);
         executeInTransaction(new JdbcUnitOfWork<Void>() {
 
             public Void execute(Connection aConnection) throws Exception {
                 IDatabaseConnection connection = new DatabaseConnection(
                     aConnection);
                 ITableFilter filter = new DatabaseSequenceFilter(connection,
-                    tables);
+                    tableNames);
                 IDataSet dataset = new FilteredDataSet(filter, connection
-                    .createDataSet(tables));
+                    .createDataSet(tableNames));
                 DatabaseOperation.DELETE_ALL.execute(connection, dataset);
                 return null;
             }
@@ -120,6 +154,7 @@ public class DatabaseUtils {
     public <T> T executeInTransaction(JdbcUnitOfWork<T> aCallback)
         throws Exception {
         Connection connection = dataSource.getConnection();
+        connection.setAutoCommit(false);
         try {
             T value = aCallback.execute(connection);
             connection.commit();
@@ -128,11 +163,7 @@ public class DatabaseUtils {
             connection.close();
         }
     }
-
-    public String[] getTableNames() throws Exception {
-        return getTableNames(tables);
-    }
-
+    
     /**
      * @throws SQLException
      */
@@ -145,10 +176,10 @@ public class DatabaseUtils {
 
         Connection connection = dataSource.getConnection();
         try {
-            ResultSet tables = connection.getMetaData().getTables(null,
+            ResultSet tableNames = connection.getMetaData().getTables(null,
                 SCHEMA_PATTERN, "%", new String[] { "TABLE" });
-            while (tables.next()) {
-                String table = tables.getString("TABLE_NAME");
+            while (tableNames.next()) {
+                String table = tableNames.getString("TABLE_NAME");
                 if (aSelection.accept(table)) {
                     result.add(table);
                 }
@@ -159,14 +190,6 @@ public class DatabaseUtils {
         }
     }
 
-    public void emptyTables() throws Exception {
-        executeOnTables(tables, new TableSetOperation() {
-            public void execute(String aTable) throws Exception {
-                emptyTable(aTable);
-            }
-        });
-    }
-
     /**
      * @return
      * @throws SQLException
@@ -187,30 +210,26 @@ public class DatabaseUtils {
     public void emptyTable(String aTable) throws Exception {
         executeSql("delete from " + aTable);
     }
-    
-    public void dropTables() throws Exception { 
-        dropTables(tables);
-    }
 
     public void dropTables(ITableFilterSimple aTables) throws Exception {
-        final String[] tables = getTableNames(aTables);
+        final String[] tableNames = getTableNames(aTables);
         String[] sortedTables = executeInTransaction(new JdbcUnitOfWork<String[]>() {
 
             public String[] execute(Connection aConnection) throws Exception {
                 IDatabaseConnection connection = new DatabaseConnection(
                     aConnection);
                 ITableFilter filter = new DatabaseSequenceFilter(connection,
-                    tables);
+                    tableNames);
                 IDataSet dataset = new FilteredDataSet(filter, connection
-                    .createDataSet(tables));
+                    .createDataSet(tableNames));
                 return dataset.getTableNames();
             }
         });
-        for (int i = sortedTables.length-1; i >= 0; i--) { 
+        for (int i = sortedTables.length - 1; i >= 0; i--) {
             dropTable(sortedTables[i]);
         }
     }
-    
+
     /**
      * @return
      * @throws SQLException