import javax.sql.DataSource;
+import junit.framework.Assert;
+
import org.apache.commons.dbcp.ConnectionFactory;
import org.apache.commons.dbcp.DriverManagerConnectionFactory;
import org.apache.commons.dbcp.PoolableConnectionFactory;
public abstract class AbstractDatabase implements Database {
+ /**
+ * Set this system property to a non-null value to ignore connection leaks
+ * when {@link #stop()} is called.
+ */
+ private static final String IGNORE_CONNECTION_LEAK_PROPERTY = "org.wamblee.database.ignoreconnectionleaks";
+
private static final Logger LOGGER = Logger
.getLogger(AbstractDatabase.class.getName());
itsDataSource = new PoolingDataSource(connectionPool);
}
+ @Override
+ public int getActiveConnections() {
+ return connectionPool.getNumActive();
+ }
+
private static void ingoredVariable(PoolableConnectionFactory aFactory) {
// Empty
}
}
started = false;
try {
+ if (connectionPool.getNumActive() > 0) {
+ String msg = "JDBC connection pool still has " +
+ connectionPool.getNumActive() +
+ " active connection(s), this is a potential resource leak in the code\n";
+ // backdoor to ignore connection leaks. Use this system property only if you
+ // can safely ignore the connection leaks.
+ if (System.getProperty(IGNORE_CONNECTION_LEAK_PROPERTY) == null) {
+ Assert.fail(msg);
+ }
+ }
connectionPool.close();
connectionPool.close();
} catch (Exception e) {