* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
- */
+ */
package org.wamblee.support.persistence;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+
import javax.sql.DataSource;
+import junit.framework.Assert;
+
import org.apache.commons.dbcp.ConnectionFactory;
import org.apache.commons.dbcp.DriverManagerConnectionFactory;
import org.apache.commons.dbcp.PoolableConnectionFactory;
import org.apache.commons.pool.impl.GenericObjectPool;
public abstract class AbstractDatabase implements Database {
+
+ /**
+ * Set this system property to a non-null value to ignore connection leaks
+ * when {@link #stop()} is called.
+ */
+ private static final String IGNORE_CONNECTION_LEAK_PROPERTY = "org.wamblee.database.ignoreconnectionleaks";
+
+ private static final Logger LOGGER = Logger
+ .getLogger(AbstractDatabase.class.getName());
+
private static final int CONNECTION_POOL_SIZE = 16;
private DataSource itsDataSource;
+ private GenericObjectPool connectionPool;
+
private boolean started;
protected AbstractDatabase() {
* This method must be called from the start method.
*/
protected final void createDataSource() {
- GenericObjectPool connectionPool = new GenericObjectPool(null);
+ connectionPool = new GenericObjectPool(null);
connectionPool.setMaxActive(CONNECTION_POOL_SIZE);
ConnectionFactory connectionFactory = new DriverManagerConnectionFactory(
getJdbcUrl(), getUsername(), getPassword());
ingoredVariable(poolableConnectionFactory);
itsDataSource = new PoolingDataSource(connectionPool);
}
-
+
+ @Override
+ public int getActiveConnections() {
+ return connectionPool.getNumActive();
+ }
+
private static void ingoredVariable(PoolableConnectionFactory aFactory) {
// Empty
}
return; // nothing to do.
}
started = false;
+ try {
+ if (connectionPool.getNumActive() > 0) {
+ String msg = "JDBC connection pool still has " +
+ connectionPool.getNumActive() +
+ " active connection(s), this is a potential resource leak in the code\n";
+ // backdoor to ignore connection leaks. Use this system property only if you
+ // can safely ignore the connection leaks.
+ if (System.getProperty(IGNORE_CONNECTION_LEAK_PROPERTY) == null) {
+ Assert.fail(msg);
+ }
+ }
+ connectionPool.close();
+ connectionPool.close();
+ } catch (Exception e) {
+ LOGGER.log(Level.WARNING, "Could not close pool", e);
+ }
doStop();
}