Config no longer implements Identifiable because this was in violation of the contrac...

[xmlrouter] / impl / src / test / java / org / wamblee / xmlrouter / impl / XMLRouterTest.java

diff --git a/impl/src/test/java/org/wamblee/xmlrouter/impl/XMLRouterTest.java b/impl/src/test/java/org/wamblee/xmlrouter/impl/XMLRouterTest.java
index 47eb21a9d7226708946e0f0da4b4cb5a62f33a31..c6b1aa0b8f65227b08b40a34442632632052e311 100644 (file)
--- a/impl/src/test/java/org/wamblee/xmlrouter/impl/XMLRouterTest.java
+++ b/impl/src/test/java/org/wamblee/xmlrouter/impl/XMLRouterTest.java
@@ -20,7 +20,10 @@ import static org.mockito.Mockito.*;
 
 import java.util.Arrays;
 import java.util.Collection;
+import java.util.UUID;
+import java.util.logging.Handler;
 import java.util.logging.Level;
+import java.util.logging.Logger;
 
 import javax.xml.transform.dom.DOMSource;
 
@@ -29,6 +32,7 @@ import org.junit.Test;
 import org.wamblee.general.SystemClock;
 import org.wamblee.xmlrouter.common.Id;
 import org.wamblee.xmlrouter.config.DocumentType;
+import org.wamblee.xmlrouter.config.Filter;
 import org.wamblee.xmlrouter.config.Transformation;
 import org.wamblee.xmlrouter.listener.EventInfo;
 import org.wamblee.xmlrouter.listener.EventListener;
@@ -64,6 +68,8 @@ public class XMLRouterTest {
         }
     }
 
+    private ExtendedRouterConfig routerConfig;
+    private XMLRouterConfiguration config;
     private XMLRouter router;
     private DOMSource source1;
     private DOMSource source2;
@@ -75,14 +81,31 @@ public class XMLRouterTest {
 
     @Before
     public void setUp() {
+
+        Logger logger = Logger.getLogger(XMLRouter.class.getName());
+        setLogLevel(logger, Level.FINEST);
+
+        routerConfig = new SingleRouterConfig("routerconfig");
+        config = new XMLRouterConfigurationImpl(routerConfig);
         EventListener logListener = new LoggingEventListener(Level.INFO);
         listener = spy(logListener);
-        router = new XMLRouter(new SystemClock(), listener);
+        router = new XMLRouter(new SystemClock(), config, listener);
         source1 = mock(DOMSource.class);
         source2 = mock(DOMSource.class);
         source3 = mock(DOMSource.class);
     }
 
+    private void setLogLevel(Logger aLogger, Level aLevel) {
+        aLogger.setLevel(aLevel);
+        for (Handler handler : aLogger.getHandlers()) {
+            handler.setLevel(Level.FINEST);
+        }
+        Logger parent = aLogger.getParent();
+        if (parent != null) {
+            setLogLevel(parent, aLevel);
+        }
+    }
+
     @Test
     public void testNoInputDocumentsRegistered() {
         Destination destination = new MyDestination(true, Arrays.asList("any"));
@@ -93,6 +116,41 @@ public class XMLRouterTest {
         verify(listener).notDelivered(any(EventInfo.class));
     }
 
+    @Test
+    public void testMisBehavingDocumentType() {
+        DocumentType type = mockDocument("docid");
+        doThrow(new RuntimeException("x")).when(type).isInstance(
+            any(DOMSource.class));
+        routerConfig.documentTypeConfig().add(type);
+        router.publish("xx", mock(DOMSource.class));
+        verify(listener).notDelivered(any(EventInfo.class));
+        // no exception should occur.
+    }
+
+    private DocumentType mockDocument(String docid) {
+        DocumentType type = mock(DocumentType.class);
+        when(type.getId()).thenReturn(new Id<DocumentType>(docid));
+        return type;
+    }
+
+    @Test
+    public void testMisBehavingFilter() {
+        registerDocumentType("any");
+        Filter filter = mockFilter("filterid");
+        doThrow(new RuntimeException("x")).when(filter).isAllowed(anyString(),
+            any(DOMSource.class));
+        routerConfig.filterConfig().add(filter);
+        router.publish("xx", mock(DOMSource.class));
+        verify(listener).notDelivered(any(EventInfo.class));
+        // no exception should occur.
+    }
+
+    private Filter mockFilter(String filterId) {
+        Filter filter = mock(Filter.class);
+        when(filter.getId()).thenReturn(new Id<Filter>(filterId));
+        return filter;
+    }
+
     @Test
     public void testOneDestinationNoTransformationSuccess() {
         destinationSpy = registerDestination(true, "any");
@@ -100,7 +158,7 @@ public class XMLRouterTest {
 
         router.publish("any", source1);
         verify(listener).delivered(any(EventInfo.class),
-            anyListOf(Transformation.class), anyLong(), anyString(), eq(true));
+            anyListOf(Transformation.class), anyString(), eq(true));
         verify(destinationSpy).receive(same(source1));
 
         // Unregister the destination.
@@ -117,17 +175,18 @@ public class XMLRouterTest {
     }
 
     private void registerDocumentType(String aType) {
-        DocumentType type = mock(DocumentType.class);
+        DocumentType type = mockDocument(UUID.randomUUID().toString());
         when(type.isInstance(any(DOMSource.class))).thenReturn(true);
         when(type.getName()).thenReturn(aType);
-        Id<DocumentType> typeId = router.addDocumentType(type);
+        routerConfig.documentTypeConfig().add(type);
     }
 
     private void registerDocumentType(String aType, DOMSource aSource) {
         DocumentType type = mock(DocumentType.class);
         when(type.isInstance(same(aSource))).thenReturn(true);
         when(type.getName()).thenReturn(aType);
-        Id<DocumentType> typeId = router.addDocumentType(type);
+        when(type.getId()).thenReturn(new Id<DocumentType>(aType));
+        routerConfig.documentTypeConfig().add(type);
     }
 
     private Destination registerDestination(boolean aResult, String... types) {
@@ -171,7 +230,7 @@ public class XMLRouterTest {
 
         router.publish("any", source1);
         verify(listener).delivered(any(EventInfo.class),
-            anyListOf(Transformation.class), anyLong(), anyString(), eq(true));
+            anyListOf(Transformation.class), anyString(), eq(true));
 
         verify(destinationSpy2).receive(same(source1));
 
@@ -200,7 +259,7 @@ public class XMLRouterTest {
             .registerDestination(destinationSpy2);
         router.publish("any", source1);
         verify(listener).delivered(any(EventInfo.class),
-            anyListOf(Transformation.class), anyLong(), anyString(), eq(true));
+            anyListOf(Transformation.class), anyString(), eq(true));
 
         verify(destinationSpy, never()).receive(same(source1));
         verify(destinationSpy2).receive(same(source1));
@@ -231,7 +290,7 @@ public class XMLRouterTest {
             .registerDestination(destinationSpy2);
         router.publish("any", source1);
         verify(listener).delivered(any(EventInfo.class),
-            anyListOf(Transformation.class), anyLong(), anyString(), eq(true));
+            anyListOf(Transformation.class), anyString(), eq(true));
 
         verify(destinationSpy, never()).receive(same(source1));
         verify(destinationSpy2).receive(same(source1));
@@ -241,11 +300,13 @@ public class XMLRouterTest {
     public void testOneTransformationOneDestination() {
         registerDocumentType("any");
         Transformation transformation = mock(Transformation.class);
-        when(transformation.getName()).thenReturn("trans");
+        when(transformation.getId())
+            .thenReturn(new Id<Transformation>("trans"));
         when(transformation.getFromType()).thenReturn("any");
         when(transformation.getToType()).thenReturn("bla");
         when(transformation.transform(same(source1))).thenReturn(source2);
-        router.addTransformation(transformation);
+        routerConfig.transformationConfig().add(transformation);
+        config.setRouterConfig(routerConfig);
 
         Destination destination = mock(Destination.class);
         when(
@@ -257,7 +318,7 @@ public class XMLRouterTest {
         when(destination.receive(any(DOMSource.class))).thenReturn(true);
         router.publish("bla", source1);
         verify(listener).delivered(any(EventInfo.class),
-            anyListOf(Transformation.class), anyLong(), anyString(), eq(true));
+            anyListOf(Transformation.class), anyString(), eq(true));
 
         verify(transformation).transform(source1);
         verify(destination).receive(same(source2));
@@ -268,10 +329,70 @@ public class XMLRouterTest {
         verify(listener).notDelivered(any(EventInfo.class));
     }
 
+    @Test
+    public void testOneTransformationOneDestinationFilterRejectsDestinationDocType() {
+        registerDocumentType("any");
+
+        Transformation transformation = mock(Transformation.class);
+        when(transformation.getId())
+            .thenReturn(new Id<Transformation>("trans"));
+        when(transformation.getFromType()).thenReturn("any");
+        when(transformation.getToType()).thenReturn("bla");
+        when(transformation.transform(same(source1))).thenReturn(source2);
+        routerConfig.transformationConfig().add(transformation);
+
+        Filter filter = mock(Filter.class);
+        when(filter.getId()).thenReturn(new Id<Filter>("f"));
+        when(filter.isAllowed(anyString(), same(source2))).thenReturn(false);
+        when(filter.isAllowed(anyString(), same(source1))).thenReturn(true);
+        routerConfig.filterConfig().add(filter);
+
+        config.setRouterConfig(routerConfig);
+
+        Destination destination = mock(Destination.class);
+        when(
+            destination.chooseFromTargetTypes((Collection<String>) anyObject()))
+            .thenReturn(Arrays.asList("bla"));
+
+        router.registerDestination(destination);
+
+        when(destination.receive(any(DOMSource.class))).thenReturn(true);
+        router.publish("bla", source1);
+        verify(listener).notDelivered(any(EventInfo.class));
+
+        verify(transformation).transform(source1);
+        verify(destination, never()).receive(any(DOMSource.class));
+    }
+
+    @Test
+    public void testMisbehavingTransformationOneDestination() {
+        registerDocumentType("any");
+        Transformation transformation = mock(Transformation.class);
+        when(transformation.getId())
+            .thenReturn(new Id<Transformation>("trans"));
+        when(transformation.getFromType()).thenReturn("any");
+        when(transformation.getToType()).thenReturn("bla");
+        doThrow(new RuntimeException("x")).when(transformation).transform(
+            same(source1));
+        routerConfig.transformationConfig().add(transformation);
+
+        Destination destination = mock(Destination.class);
+        when(
+            destination.chooseFromTargetTypes((Collection<String>) anyObject()))
+            .thenReturn(Arrays.asList("bla"));
+
+        router.registerDestination(destination);
+
+        when(destination.receive(any(DOMSource.class))).thenReturn(true);
+        router.publish("bla", source1);
+        verify(listener).notDelivered(any(EventInfo.class));
+    }
+
     private Transformation createTransformation(String aFrom, String aTo,
         DOMSource aSource, DOMSource aTarget) {
         Transformation transformation = mock(Transformation.class);
-        when(transformation.getName()).thenReturn("trans");
+        when(transformation.getId()).thenReturn(
+            new Id<Transformation>(UUID.randomUUID().toString()));
         when(transformation.getFromType()).thenReturn(aFrom);
         when(transformation.getToType()).thenReturn(aTo);
         when(transformation.transform(same(aSource))).thenReturn(aTarget);
@@ -284,8 +405,8 @@ public class XMLRouterTest {
         Transformation transformation = createTransformation("any", "bla",
             source1, null);
 
-        router.addTransformation(transformation);
-
+        routerConfig.transformationConfig().add(transformation);
+        config.setRouterConfig(routerConfig);
         Destination destination = mock(Destination.class);
         when(
             destination.chooseFromTargetTypes((Collection<String>) anyObject()))
@@ -302,13 +423,15 @@ public class XMLRouterTest {
         Transformation transformation2 = createTransformation("any", "bla2",
             source1, source2);
 
-        router.addTransformation(transformation2);
+        routerConfig.transformationConfig().add(transformation2);
+        config.setRouterConfig(routerConfig);
         when(
             destination.chooseFromTargetTypes((Collection<String>) anyObject()))
             .thenReturn(Arrays.asList("bla", "bla2"));
 
         reset(transformation);
-        when(transformation.getName()).thenReturn("trans");
+        when(transformation.getId())
+            .thenReturn(new Id<Transformation>("trans"));
         when(transformation.getFromType()).thenReturn("any");
         when(transformation.getToType()).thenReturn("bla");
         when(transformation.transform(same(source1))).thenReturn(null);
@@ -316,7 +439,7 @@ public class XMLRouterTest {
         when(destination.receive(any(DOMSource.class))).thenReturn(true);
         router.publish("bla", source1);
         verify(listener).delivered(any(EventInfo.class),
-            anyListOf(Transformation.class), anyLong(), anyString(), eq(true));
+            anyListOf(Transformation.class), anyString(), eq(true));
 
         verify(transformation).transform(source1);
         verify(transformation2).transform(source1);
@@ -333,7 +456,7 @@ public class XMLRouterTest {
 
         router.publish("source", source1);
         verify(listener, times(2)).delivered(any(EventInfo.class),
-            anyListOf(Transformation.class), anyLong(), anyString(), eq(true));
+            anyListOf(Transformation.class), anyString(), eq(true));
 
         verify(dest1).receive(same(source1));
         verify(dest2).receive(same(source1));
@@ -346,11 +469,12 @@ public class XMLRouterTest {
         registerDocumentType("other", source2);
         Transformation transformation = createTransformation("any", "other",
             source1, source2);
-        router.addTransformation(transformation);
+        routerConfig.transformationConfig().add(transformation);
+        config.setRouterConfig(routerConfig);
 
         router.publish("source", source1);
         verify(listener, times(2)).delivered(any(EventInfo.class),
-            anyListOf(Transformation.class), anyLong(), anyString(), eq(true));
+            anyListOf(Transformation.class), anyString(), eq(true));
 
         verify(dest).receive(same(source1));
         verify(dest).receive(same(source2));
@@ -364,18 +488,45 @@ public class XMLRouterTest {
 
         Transformation t1 = createTransformation("any", "intermediate",
             source1, source2);
-        router.addTransformation(t1);
+        routerConfig.transformationConfig().add(t1);
         Transformation t2 = createTransformation("intermediate", "other",
             source2, source3);
-        router.addTransformation(t2);
+        routerConfig.transformationConfig().add(t2);
+        config.setRouterConfig(routerConfig);
 
         router.publish("source", source1);
         verify(listener).delivered(any(EventInfo.class),
-            anyListOf(Transformation.class), anyLong(), anyString(), eq(true));
+            anyListOf(Transformation.class), anyString(), eq(true));
 
         verify(dest).receive(same(source3));
     }
 
+    @Test
+    public void testMultipleTransformationsFilterRejectsIntermediateDocument() {
+        Destination dest = registerDestination(true, "other");
+        registerDocumentType("any", source1);
+        registerDocumentType("other", source3);
+
+        Transformation t1 = createTransformation("any", "intermediate",
+            source1, source2);
+        routerConfig.transformationConfig().add(t1);
+        Transformation t2 = createTransformation("intermediate", "other",
+            source2, source3);
+        routerConfig.transformationConfig().add(t2);
+        config.setRouterConfig(routerConfig);
+
+        Filter filter = mock(Filter.class);
+        when(filter.getId()).thenReturn(new Id<Filter>("f"));
+        when(filter.isAllowed(anyString(), same(source1))).thenReturn(true);
+        when(filter.isAllowed(anyString(), same(source2))).thenReturn(false);
+        when(filter.isAllowed(anyString(), same(source3))).thenReturn(true);
+        routerConfig.filterConfig().add(filter);
+
+        router.publish("source", source1);
+        verify(listener).notDelivered(any(EventInfo.class));
+        verify(dest, never()).receive(any(DOMSource.class));
+    }
+
     @Test
     public void testDestinationGivesError() {
         Destination destination = mock(Destination.class);
@@ -391,7 +542,7 @@ public class XMLRouterTest {
         router.publish("source", source1);
 
         verify(listener).delivered(any(EventInfo.class),
-            anyListOf(Transformation.class), anyLong(), anyString(), eq(false));
+            anyListOf(Transformation.class), anyString(), eq(false));
 
     }
 }